Skip to content

tooltip text for close button is internationalized (2) #245333

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
TylerLeonhardt merged 2 commits into from
Apr 2, 2025
Merged

tooltip text for close button is internationalized (2) #245333

TylerLeonhardt merged 2 commits into from
Apr 2, 2025

Conversation

@manabu-nakamura
Copy link
Contributor

@manabu-nakamura manabu-nakamura commented Apr 2, 2025

The tooltip text for the other close button ("Close banner") is also not localized.
ja
It is internationalized in this PR.
Fixes #245194

https://github.com/microsoft/vscode-loc/blob/main/i18n/vscode-language-pack-ja/translations/main.i18n.json:

+		"vs/editor/contrib/unicodeHighlighter/browser/bannerController": {
+			"closeBanner": "バナーを閉じる"
+		},

ja2

@TylerLeonhardt TylerLeonhardt enabled auto-merge (squash) April 2, 2025 12:45
@TylerLeonhardt
Copy link
Member

TylerLeonhardt commented Apr 2, 2025

Thanks for picking this up!

@vs-code-engineering vs-code-engineering bot added this to the April 2025 milestone Apr 2, 2025
@TylerLeonhardt TylerLeonhardt merged commit c59097e into microsoft:main Apr 2, 2025
7 checks passed
@manabu-nakamura manabu-nakamura deleted the banner2 branch April 2, 2025 13:32
@vs-code-engineering vs-code-engineering bot locked and limited conversation to collaborators May 17, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@TylerLeonhardt TylerLeonhardt TylerLeonhardt approved these changes

@alexr00 alexr00 alexr00 approved these changes

Assignees

@TylerLeonhardt TylerLeonhardt

Labels

None yet

Projects

None yet

Milestone

April 2025

Development

Successfully merging this pull request may close these issues.

tooltip text of close button ("Close Banner") is not translated

3 participants

@manabu-nakamura @TylerLeonhardt @alexr00