Skip to content

fix: correct filtering logic for file-based recommendations #245062

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
sandy081 merged 1 commit into from
Apr 2, 2025
Merged

fix: correct filtering logic for file-based recommendations #245062

sandy081 merged 1 commit into from
Apr 2, 2025

Conversation

@bytemain
Copy link
Contributor

@bytemain bytemain commented Mar 30, 2025

The filtering logic was inverted, causing recommendations to be incorrectly included instead of excluded. This fix ensures that only non-prompted recommendations are considered.

@bytemain
fix: correct filtering logic for file-based recommendations
47576d2 
The filtering logic was inverted, causing recommendations to be incorrectly included instead of excluded. This fix ensures that only non-prompted recommendations are considered.
@rzhao271 rzhao271 assigned sandy081 and unassigned rzhao271 Mar 31, 2025
@sandy081
Copy link
Member

sandy081 commented Mar 31, 2025

Can you please first explain the issue you are seeing and steps to reproduce?

@bytemain
Copy link
Contributor Author

bytemain commented Apr 2, 2025

  1. When invoking the workbench.extensions.uninstallExtension function for a built-in extension, an error message is displayed stating "Built-in extension and cannot be installed". However, it should say "Built-in extension and cannot be uninstalled".
  2. The file-based recommendations logic only shows extensions that have been previously prompted. For instance, if you previously saw recommendations for the python and python debugger extensions, and Visual Studio Code adds a new recommended extension, such as python environment, you will never see this newly added extension. This is because it is filtered out by the logic that filters prompted recommendations.

@sandy081
Copy link
Member

sandy081 commented Apr 2, 2025

Good catch

@sandy081 sandy081 enabled auto-merge (squash) April 2, 2025 11:53
@vs-code-engineering vs-code-engineering bot added this to the April 2025 milestone Apr 2, 2025
@sandy081 sandy081 merged commit 1010065 into microsoft:main Apr 2, 2025
7 checks passed
@vs-code-engineering vs-code-engineering bot locked and limited conversation to collaborators May 17, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@sandy081 sandy081 sandy081 approved these changes

@alexr00 alexr00 alexr00 approved these changes

Assignees

@sandy081 sandy081

Labels

triage-needed

Projects

None yet

Milestone

April 2025

Development

Successfully merging this pull request may close these issues.

4 participants

@bytemain @sandy081 @alexr00 @rzhao271