Skip to content

Conversation

@nomike
Copy link
Contributor

@nomike nomike commented Mar 29, 2025

Fixes #245022.

Steps to test the fix

  1. Sign up for GitHub
  2. Create repository "test" on GitHub
  3. Rename that repository to "test-renamed"
  4. Login to your GitHub account from within vscode
  5. Initialize a new git repository in vscode and commit a test file
  6. Chose the "Publish to GitHub" command
  7. Use "test" as a repository name

With the current version, vscode will complain that the repository already exists, even though it no longer does.
My MR fixes this, publishing is now possible again.

Testing

I don't thing it's feasible to write a unit test for this, as that would require a GitHub account and a repository which needs to be created and deleted on each test run.

@lszomoru lszomoru added the github Github extension label May 27, 2025
@lszomoru lszomoru added this to the May 2025 milestone May 27, 2025
@lszomoru lszomoru enabled auto-merge (squash) May 27, 2025 11:35
Copy link
Member

@lszomoru lszomoru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much for your contribution.

@lszomoru lszomoru merged commit c80442d into microsoft:main May 27, 2025
7 checks passed
@vs-code-engineering vs-code-engineering bot locked and limited conversation to collaborators Jul 11, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

github Github extension

Projects

None yet

Development

Successfully merging this pull request may close these issues.

GitHub - publish doesn't work if name was in use before, fails with "GitHub repository already exists"

3 participants