Fix hasEdits flag's value when updating multiple values in JSONEditingService #243876
Merged
sandy081 merged 1 commit intomicrosoft:mainfrom Mar 19, 2025
Merged
Conversation
83a0ec3 to
776a6f0
Compare
776a6f0 to
f938d0d
Compare
sandy081
approved these changes
Mar 19, 2025
aiday-mar
approved these changes
Mar 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi @sandy081,
This commit (5bca175#diff-4c16f60ba3ea06c8c7dfd2a525ab8bbd55ebf12a7914855cb0f56bdfc9c3c1e7R53) added support for updating multiple values in the
JSONEditingService. ThehasEditsflag is used to check whether there are actual changes and whether the JSON needs to be saved.However, based on the code, it appears that the value of
hasEditsonly reflects from the last value. Shouldn'thasEditsbe true as long as any one of the values actually modifies the JSON, rather than only being true if the last value modifies the JSON?