A lot of the code below assumes that resource will be a file, not a directory

Instead I think this check should happen down where we set the Mimes.uriList data. That logic should be updated to also include directories in the url-list

Sure, will update accordingly.

Can you describe some scenarios, through which I can test the change?

It should work the same as with the PR but using a more correct data-transfer type instead of the editors type. That could potentially result in VS Code trying to open a folder as an editor, while url-list should work for any type of file or folder

Got it. 👍
Thank you for your prompt reply.

I reviewed the code in detail and found that the flow is identical for both files and directories. To ensure that the if (draggedEditors.length) condition is met (which is required for setting the MIME type), we need to add the editor to the draggedEditors list.

Additionally, textFileModel is undefined for both files and directories:

The most reasonable approach seems to be adding a separate condition for directories, like this:

} else if (!resourceOrEditor.isDirectory) {
	editor = {
		resource: resourceOrEditor.resource,
		options: { selection: resourceOrEditor.selection }
	};
} else if (resourceOrEditor.isDirectory) {
	editor = {
		resource: resourceOrEditor.resource,
		options: { selection: undefined } // or resourceOrEditor.selection
	};
}

Since this is my first contribution to this repo, I’d appreciate any guidance on whether this approach aligns with the expected changes or if there are additional considerations I should address.

It may be easier to add a new draggedDirectories variable to go with with draggedEditors. A directory should never end up in draggedEditors

Then update the code where we build the uriListEntries to loop through both the draggedEditors and draggedDirectories

Sure, will update the code soon.

We want to write both files and dirs in this case

It looks like maybe a few too many lines got touch in this change. Maybe instead of adding draggedDirectories and draggedFiles, you can make the fix clearer by focusing on the part below where we built the url-list. You can use use fileSystemResources to get the directories and combine those with the dragged editors. Something like:

if (draggedEditors.length) {
   event.dataTransfer.setData(CodeDataTransfers.EDITORS, stringify(draggedEditors));
}

const allDraggedResources = [
    ...draggedEditors.map(editor => resource),
    ...fileSystemResources.filter(({ isDirectory }) => isDirectory).map(dir => dir.resource)
]
if (allDraggedResources.length) {
    // set url-list
}

Since filter creates a copy of the array, you can simplify this to: const draggedDirectories = fileSystemResources .filter(...) without using spread

Sure.

If we don't set directories here, it does not solve the bug.