# Extend the partial accept handler#241356
Open
marrej wants to merge 6 commits intomicrosoft:mainfrom
Open
Conversation
Member
|
Thanks for the PR! I believe the properties shouldn't be optional though. If data is provided, it should always be provided, otherwise every consumer will wonder about the cases in which they are not available. |
Contributor
Author
|
Fair point. Let me modify it so the data can be required. Thanks! |
Contributor
Author
|
Hey @hediet I made the properties required and updated it for the suggest completion. Let me know if there is anything else you'd like to handle :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The main problem with the current partial acceptance is that it provides the full length of the original insertion, rather than just the added content to the editor. Having access to the addedLength would allow completion providers to truthfully report the change in characters.
The versionBeforeAcceptance can be used by the extensions to truthfully report the state sequence and changes
ReplacementRange allows to better track the original intended edit at the version of acceptance.
closes #195369