Add option to move the Find dialog to the bottom of the document view#238345
Add option to move the Find dialog to the bottom of the document view#238345crestyeagle wants to merge 4 commits intomicrosoft:mainfrom
Conversation
Fixes microsoft#238337 Add option to move the Find dialog to the bottom of the document view. * Update `OverlayWidgetPositionPreference` enum in `src/vs/editor/browser/editorBrowser.ts` to include a new value `BOTTOM_CENTER`. * Modify `FindWidget` class in `src/vs/editor/contrib/find/browser/findWidget.ts` to support positioning the Find dialog at the bottom based on the new configuration option. * Adjust `_reveal` and `_hide` methods in `src/vs/editor/contrib/find/browser/findWidget.ts` to handle the new bottom position. * Add CSS styles in `src/vs/editor/contrib/find/browser/findWidget.css` to handle the new bottom position of the Find dialog. --- For more details, open the [Copilot Workspace session](https://copilot-workspace.githubnext.com/microsoft/vscode/issues/238337?shareId=XXXX-XXXX-XXXX-XXXX).
@microsoft-github-policy-service agree |
* Update `OverlayWidgetPositionPreference` enum in `editorBrowser.ts` to include `BOTTOM_CENTER`, `LEFT_CENTER`, and `RIGHT_CENTER` * Modify `FindWidget` class in `findWidget.ts` to support positioning the Find dialog at the bottom, left, or right based on the new configuration option * Adjust `_reveal` and `_hide` methods in `findWidget.ts` to handle the new positions * Add CSS styles in `findWidget.css` to handle the new bottom, left, and right positions of the Find dialog
|
I am trying to figure out why one of the tests is failing. hopefully I should have a fix in a day or two. |
|
The result of the failed CI has long since gone due to its age, but what failed was the gulp hygiene check. I remember it said that monaco was outdated or something, so maybe you can confirm the version on your side and try again. |
okay. I was also having issues on my local with some node dependencies and was therefore unable to properly test it locally so maybe a bug slipped passed and also I have been a bit away so was unable to look at it again but I'll take a look as soon as I can. |
|
Thanks for the PR! Let's wait a bit to see how much the referenced feature request is in demand! |
Fixes #238337
Add option to move the Find dialog to the bottom of the document view.
OverlayWidgetPositionPreferenceenum insrc/vs/editor/browser/editorBrowser.tsto include a new valueBOTTOM_CENTER.FindWidgetclass insrc/vs/editor/contrib/find/browser/findWidget.tsto support positioning the Find dialog at the bottom based on the new configuration option._revealand_hidemethods insrc/vs/editor/contrib/find/browser/findWidget.tsto handle the new bottom position.src/vs/editor/contrib/find/browser/findWidget.cssto handle the new bottom position of the Find dialog.For more details, open the Copilot Workspace session.