fix: add key match score, revert contiguous search#237855
Merged
Conversation
Collaborator
Author
|
TODO:
|
050f5bc to
8a00b20
Compare
TylerLeonhardt
approved these changes
Jan 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #203838
Fixes #226039
The main issue was that we restricted the key matching algorithm to match contiguous strings only. Reverting the match back to non-contiguous searching matches more cases again. One side effect is there are now many more results with certain queries such as "editor formonpast", but I also added a new field that should prioritize better matches and help move them to the top of all the noise.
CC @jrieken.