Add debug/watch/context to list of valid menu extension points#237751
Conversation
|
Does the title of this PR need correcting? |
|
Yea this should be fine, we already have similar menu extension points for other places variables/expressions are shown |
roblourens
left a comment
There was a problem hiding this comment.
Did anybody try this?
The hard part about this is what the toolbar context should be. We need to define a new object which is safe to serialize and has a reasonable shape, and then that object is basically API
Head branch was pushed to by a user without write access
2976886
|
I had a stab at the watch view context. In the interests of doing the least harm I added a toJSON to the Expression class which serializes it to the same thing the Variables view does - basically a session id and a DAP Variable. The Variables view seems to work around the same problem by using a global variable 'variableInternalContext'. I like my idea better! While I was in there, I moved the data breakpoint commands to debugCommands.ts, and added them to the Watch view. |
|
Does this duplicate #212501 |
|
@thegecko - huh; it looks like it does - although I'm only trying to bring the Watch panel to parity with Variables. Sorry I didn't notice yours. |
|
@roblourens is there any realistic chance of you looking at this, or should I abandon it? |
1fe13cd
|
thanks! |
This is a fix for #237750 - it just adds debug/watch/context to the list of valid menu extension points, which I presume was accidentally missed.