bun.lock as package manager lockfile
#236012
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as resolved.
This comment was marked as resolved.
remcohaszing
approved these changes
Dec 13, 2024
aeschli
approved these changes
Dec 16, 2024
lszomoru
approved these changes
Dec 16, 2024
songjianet
approved these changes
Dec 20, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extends #235917 by adding it to more places.
Also with
jsoncit gives warnings about trailing comma, but we have made intentional decision to have them, so what is the best way to suppress them (ie not have whole file full of warnings)jsonValidationandallowTrailingCommas, but just wondered the best official way wasexample here: oven-sh/bun#15705