Issue: #214481 Add Option to Ignore Code Blocks in Text-to-Speech #235697
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as spam.
This comment was marked as spam.
bpasero
requested changes
Dec 11, 2024
Member
bpasero
left a comment
There was a problem hiding this comment.
The approach in principle makes sense to me but it does not work: the chunk from here:
const { chunk, offset } = this.parseNextChatResponseChunk(response, totalOffset);
No longer contains any backticks. They are removed when calling renderStringAsPlaintext I believe, can you check?
This was referenced Dec 11, 2024
bpasero
previously approved these changes
Dec 11, 2024
Member
|
Thanks! |
dbaeumer
previously approved these changes
Dec 11, 2024
Member
|
@jaymroy can you agree to the CLA bot? |
Contributor
Author
@microsoft-github-policy-service agree |
meganrogge
approved these changes
Dec 11, 2024
src/vs/workbench/contrib/chat/electron-sandbox/actions/voiceChatActions.ts
Show resolved
Hide resolved
DonJayamanne
approved these changes
Dec 12, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #214481
Implementation of a requested feature
I introduced a new setting under the existing accessibility.voice.* namespace, modified the nextChatResponseChunk generator to track code block boundaries and stopped synthesizing text within the code blocks when the setting is enabled.