Horizontal dragging auto-scroll#235174
Merged
alexdima merged 13 commits intomicrosoft:mainfrom Jul 14, 2025
Merged
Conversation
Contributor
Author
|
@microsoft-github-policy-service agree |
ttttotem
commented
Dec 3, 2024
gigarrees
approved these changes
Jan 10, 2025
Contributor
Author
|
@microsoft-github-policy-service agree |
alexdima
approved these changes
Jul 14, 2025
bpasero
approved these changes
Jul 14, 2025
Contributor
|
Hi @ttttotem thanks for this PR. By git bisecting I have found that this PR causes the issue : #263098. Specifically it's the changes in the file
The linked issue is rather important so it should maybe made into a candidate with a quick fix. |
Contributor
|
To add more context about the issue above, the PR incorrectly computes that the cursor is outside of the editor, when it is inside of the editor in the following check: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue: #172652
Problem: horizontal dragging does not autoscroll
Solution:
Extension of vertical autoscroll introduced in #161378
Example:
https://github.com/user-attachments/assets/cee1f841-9a00-42bd-844d-9c4d4cecf1f6