Skip to content

Conversation

@janajar
Copy link
Contributor

@janajar janajar commented Dec 2, 2024

Fixes issue #233200
Added a null check for matchRange in the iterateThroughMatches function to ensure setSelection is only called with valid arguments.

Authored with @aayyob

Added a null check for matchRange in the iterateThroughMatches
function to ensure setSelection is only called with valid arguments.
@janajar
Copy link
Contributor Author

janajar commented Dec 2, 2024

@microsoft-github-policy-service agree

@janajar janajar changed the title Fix: When no results in search editor it throws an error #233200 Fix: When no results in search editor it throws an error Dec 5, 2024
@roblourens roblourens added this to the January 2025 milestone Dec 10, 2024
@janajar
Copy link
Contributor Author

janajar commented Dec 13, 2024

Hi @roblourens,
This is ready to merge once you approve it.

Copy link
Member

@roblourens roblourens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@roblourens roblourens enabled auto-merge (squash) December 14, 2024 01:38
@roblourens roblourens merged commit 1dc517c into microsoft:main Dec 14, 2024
7 checks passed
@janajar janajar deleted the janajar/bug/no-results-search branch December 15, 2024 23:23
@vs-code-engineering vs-code-engineering bot locked and limited conversation to collaborators Jan 28, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants