Skip to content

Eslint 9 migration#230345

Merged
mjbvz merged 12 commits intomainfrom
dev/eslint-9
Oct 7, 2024
Merged

Eslint 9 migration#230345
mjbvz merged 12 commits intomainfrom
dev/eslint-9

Conversation

@mjbvz
Copy link
Collaborator

@mjbvz mjbvz commented Oct 2, 2024 •
edited
Loading

Fixes #230339

Migrates us to eslint 9 and a flat config

TODO:

  • Migrate main eslint
  • Fix local rules
  • Convert remaining eslintrc files
  • Fix all lint errors
  • Validate build scripts still work
  • Validate editor tooling still works

Follow ups:

  • All local rules should have proper schemas (worked around by setting schema: false
  • Fix the remaining unsafe casts (or really leave them suppressed)

mjbvz added 2 commits October 2, 2024 14:45
@mjbvz
Start eslint 9 migration
e456f4c 
For #230339

Starts migrating to eslint 9. Everything runs but it produces a number of errors
@mjbvz
Merge branch 'main' into dev/eslint-9
489c180
mjbvz
mjbvz commented Oct 3, 2024
View reviewed changes
mjbvz
mjbvz commented Oct 3, 2024
View reviewed changes
@mjbvz
Add explicit semver types
546ea6d 
These seem to have getting pulled in implicitly before
@mjbvz mjbvz changed the title Start eslint 9 migration Eslint 9 migration Oct 3, 2024
@sandy081
Copy link
Member

sandy081 commented Oct 3, 2024 •
edited
Loading

@mjbvz Pushed a change to use allowImportNames for one of the rules I have created. This is available from version 9.

@mjbvz mjbvz marked this pull request as ready for review October 3, 2024 18:21
@mjbvz mjbvz requested a review from jrieken as a code owner October 3, 2024 18:21
@mjbvz
Copy link
Collaborator Author

mjbvz commented Oct 3, 2024

Checks look good. Build script pass and I tested introducing a few errors and confirming they were reported. Planning to merge but please keep an eye out for any regressions or cases where our custom rules no longer apply

@mjbvz mjbvz added this to the October 2024 milestone Oct 3, 2024
@mjbvz mjbvz enabled auto-merge October 3, 2024 18:27
lramos15
lramos15 previously approved these changes Oct 3, 2024
View reviewed changes
@mjbvz
Copy link
Collaborator Author

mjbvz commented Oct 3, 2024

cc @jrieken. Need your review as code owner as I touched vscode.d.ts to fix some new linting errors that were discovered

Tyriar
Tyriar requested changes Oct 4, 2024
View reviewed changes
jrieken
jrieken reviewed Oct 4, 2024
View reviewed changes
Copy link
Member

@jrieken jrieken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 for changes in src/vscode-dts/vscode.d.ts

@mjbvz
Copy link
Collaborator Author

mjbvz commented Oct 4, 2024

Fixed merge conflicts and pushed a few small fixes

@jrieken If the changes look good, can you please approve the pr through a GitHub review too. It seems like our code owner rules require that either you or I approve any changes to vscode.d.ts

@mjbvz mjbvz requested review from Tyriar and jrieken October 4, 2024 20:31
Tyriar
Tyriar approved these changes Oct 7, 2024
View reviewed changes
Copy link
Member

@Tyriar Tyriar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My parts all good

@mjbvz mjbvz merged commit e2e048d into main Oct 7, 2024
@mjbvz mjbvz deleted the dev/eslint-9 branch October 7, 2024 16:15
@tmm1 tmm1 mentioned this pull request Oct 10, 2024
Closed
@vs-code-engineering vs-code-engineering bot locked and limited conversation to collaborators Nov 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@bpasero bpasero bpasero left review comments

@jrieken jrieken jrieken approved these changes

@Tyriar Tyriar Tyriar approved these changes

@lramos15 lramos15 lramos15 left review comments

Assignees

@mjbvz mjbvz

Labels

None yet

Projects

None yet

Milestone

October 2024

Development

Successfully merging this pull request may close these issues.

Adopt eslint flat configs

6 participants

@mjbvz @sandy081 @bpasero @jrieken @Tyriar @lramos15