Marker message white-space nowrap -> pre#229454
Merged
sandy081 merged 4 commits intomicrosoft:mainfrom Oct 21, 2024
Merged
Conversation
sandy081
approved these changes
Oct 21, 2024
aeschli
approved these changes
Oct 21, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #229112
The mentioned issue highlights a collapsing of whitespace for issues in the problems pane
The use of
whitespace: nowrapis inappropriate here, since it collapses desirable whitespace (both leading and internal) for each line of the problem.The following table from MDN lays out our options.
nowrapdoesn't preserve whitespace (bad), but it does prevent text wrapping (good)predoes preserve whitespace, while also preventing text wrappingnormalnowrapprepre-wrappre-linebreak-spacesI'm not sure what I need to do to run my build of VS Code locally with the extension I'm using that publishes this particular diagnostic from my reproduction. Here is a screenshot of making the suggested change to the CSS with the dev tools. You can see the desired leading whitespace is no longer collapsed on the error pane.