Skip to content

Fix typo: context view anchor option might be dismissed when using ||#228896

Merged
benibenj merged 2 commits intomicrosoft:mainfrom
Bistard:contextView-typo
Oct 22, 2024
Merged

Fix typo: context view anchor option might be dismissed when using ||#228896
benibenj merged 2 commits intomicrosoft:mainfrom
Bistard:contextView-typo

Conversation

@Bistard
Copy link
Copy Markdown
Contributor

@Bistard Bistard commented Sep 18, 2024

  1. Using || will dismiss the anchor option if the anchorPosition/anchorAlignment/anchorAxisAlignment is an enum with value 0.
  2. I replace the || with ??.

@Bistard Bistard changed the title Fix typo: context view anchor option might be dismissed Fix typo: context view anchor option might be dismissed when using || Sep 18, 2024
@joaomoreno joaomoreno assigned joaomoreno and unassigned ulugbekna Oct 14, 2024
@joaomoreno joaomoreno added this to the October 2024 milestone Oct 14, 2024
@benibenj benibenj enabled auto-merge (squash) October 22, 2024 07:42
@benibenj benibenj merged commit 3546da5 into microsoft:main Oct 22, 2024
@Bistard Bistard deleted the contextView-typo branch October 22, 2024 07:53
@vs-code-engineering vs-code-engineering bot locked and limited conversation to collaborators Dec 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants