Merge diverging findExecutable functions #228373
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Patch missing from win32.findExecutable: - microsoft@e52382a Patch missing from findExecutable: - microsoft@9bc292a
Due to the previous change, this path.join ended up joining two absolute paths in some cases. findExecutable now returns undefined if the path does not exist, even if it is absolute. So it is no longer correct to assume that `command` was relative if `foundExecutable` is undefined.
Member
|
I think that method in base came original in from @dbaeumer in 41c02aa#diff-de2b1c04d060553d3bcfbc49b0157a508856c67c9979ff84b54aa5dd59e5e602 |
meganrogge
approved these changes
Dec 11, 2024
Contributor
meganrogge
left a comment
There was a problem hiding this comment.
Thanks, your fix works!
Tyriar
approved these changes
Dec 11, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These two functions were mostly the same but they were out of sync, so some patches were missing from one, resulting in task execution bugs that only affected Mac/Linux: #158914.
Patch missing from win32.findExecutable:
Patch missing from findExecutable: