Update marked #225096
Merged
Update marked #225096
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This bumps our marked version from 4.x to 14.x. This fixes a number of bugs in markdown parsing however is somewhat risky as we've missed so many versions. Hoping to merge early in the iteration so we can catch any potential issues
mjbvz
commented
Aug 7, 2024
| return null; | ||
| } | ||
|
|
||
| function completeCodeBlock(tokens: marked.Token[], leader: string): marked.Token[] { |
Collaborator
Author
There was a problem hiding this comment.
The new version of marked does this automatically. However it does not close the other elements automatically so we can't remove all of fillInIncompleteTokens
Member
There was a problem hiding this comment.
Nice, if it did it for all elements automatically I would be so annoyed haha
Copying over marked-highlight for now
DonJayamanne
approved these changes
Aug 8, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This bumps our marked version from 4.x to 14.x. This fixes a number of bugs in markdown parsing however is somewhat risky as we've missed so many versions. Hoping to merge early in the iteration so we can catch any potential issues
cc @alexr00 @roblourens