Fix the unexpected console error that occurs when updating the shadow dom selection in monaco-editor#215780
Merged
alexdima merged 5 commits intomicrosoft:mainfrom Jul 15, 2025
Merged
Conversation
ppc-harmoney
approved these changes
Sep 6, 2024
|
@alexdima I don't mean to nag you, but do you have an idea of when this could be reviewed? We are seeing a lot of errors in our logging and would like this patch to be included. |
alexdima
approved these changes
Jul 15, 2025
Tyriar
approved these changes
Jul 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix: monaco-editor issue: [Bug] error when selecting text with mouse in shadow dom
When creating the Monaco Editor using Shadow DOM, an error may occur when updating the selection, as depicted below:
The Reason:
The element retrieved from:
could potentially be the
div.monaco-mouse-cursor-textelement, which doesn't have any child nodes. Consequently, the following code snippet is consistently incorrect, causing thesetRangemethod's first parameter to be null:Previously, this error had been overlooked by not console:
However, in a recent update where the lazy.ts was used to wrap the methods of updating the selection, this error was caught: