feature: support font family picker in settings#214572
Merged
rzhao271 merged 29 commits intomicrosoft:mainfrom Mar 10, 2025
Merged
feature: support font family picker in settings#214572rzhao271 merged 29 commits intomicrosoft:mainfrom
rzhao271 merged 29 commits intomicrosoft:mainfrom
Conversation
Member
|
Doesn't seem to work for me? 
|
Contributor
Author
|
Hm, it worked for me on Linux and Windows. When running the vscode from source in this branch, does
I'm not quite sure why it's not working for you, perhaps something might be different on Macos? |
Collaborator
|
I finally had some time to take a look at this PR and can confirm that it works on Windows.
|
Collaborator
|
PR LGTM. |
rzhao271
approved these changes
Mar 10, 2025
deepak1556
reviewed
Mar 10, 2025
alexr00
approved these changes
Mar 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Helps with #128355.
This is based on the Pull Request by @Tyriar and adds
defaultSnippetsforeditor.fontFamilyandterminal.integrated.fontFamily.Testing
For testing, open the
settings.jsonfile and verify that completions foreditor.fontFamilyare visible.Additional information
The completions for the settings ui are not supported, only the settings json editor.