Fix: prevent view shift when enable minimap with right-click on the scrollbar#210510
Merged
alexdima merged 7 commits intomicrosoft:mainfrom Jul 15, 2025
Merged
Fix: prevent view shift when enable minimap with right-click on the scrollbar#210510alexdima merged 7 commits intomicrosoft:mainfrom
alexdima merged 7 commits intomicrosoft:mainfrom
Conversation
Contributor
Author
|
#198636 should fix the scrollbar part. I have not figured out how to make the view not shift when right-click on the minimap scrollbar yet. I couldn't find out why right-click being recognized and registered as a ScrollEvent, which makes the view shift |
Contributor
Author
|
Will my PR ever get reviewed? 🥺 |
- for mouse events, only allow left button events
alexdima
approved these changes
Jul 15, 2025
DonJayamanne
approved these changes
Jul 15, 2025
Contributor
Author
|
@microsoft-github-policy-service agree |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
How to test: right click on the scrollbar (but not on the slider), the current view should not shift anymore