fix: don't show terminal suggestions when keybindings are sent through to shell#208523
Merged
Tyriar merged 2 commits intomicrosoft:mainfrom Mar 27, 2024
cpendery:fix/suggestions-with-no-keybindings
Merged
fix: don't show terminal suggestions when keybindings are sent through to shell#208523Tyriar merged 2 commits intomicrosoft:mainfrom cpendery:fix/suggestions-with-no-keybindings
Tyriar merged 2 commits intomicrosoft:mainfrom
cpendery:fix/suggestions-with-no-keybindings
Conversation
…h to shell Signed-off-by: Chapman Pendery <cpendery@microsoft.com>
Member
Author
|
@Tyriar for review |
Tyriar
previously approved these changes
Mar 25, 2024
Comment on lines
+67
to
+68
| this._addon?.dispose(); | ||
| this._addon = undefined; |
Member
There was a problem hiding this comment.
A good pattern to use here: private _addon: MutableDisposable<SuggestAddon>
Signed-off-by: Chapman Pendery <cpendery@microsoft.com>
auto-merge was automatically disabled
March 25, 2024 22:29
Head branch was pushed to by a user without write access
bpasero
approved these changes
Mar 26, 2024
Tyriar
approved these changes
Mar 27, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When
terminal.integrated.sendKeybindingsToShellistrue, we probably shouldn't show the suggestion widget since the user will only be able to interact with it via mouse. I thought the widget was broken until I checked my settings.Part of #154662