Inline Edit - make sure we finalize accepting before requesting new edit#206525
Merged
hediet merged 2 commits intomicrosoft:mainfrom Mar 7, 2024
Merged
Inline Edit - make sure we finalize accepting before requesting new edit#206525hediet merged 2 commits intomicrosoft:mainfrom
hediet merged 2 commits intomicrosoft:mainfrom
Conversation
hediet
reviewed
Mar 4, 2024
src/vs/editor/contrib/inlineEdit/browser/inlineEditController.ts
Outdated
Show resolved
Hide resolved
Member
|
I think it would be cleaner if accepting the edit would transfer ownership of the command-reference from the inline completion controller to the async accept method (which is then disposed when the accept method finishes). class RefCounted<T : IDisposable> : IDisposable {
/** Takes over ownership of `value` */
constructor(public readonly value: T) {}
/** Creates a new reference to the data. */
clone(): RefCounted<T> { ... }
/** Disposes this reference. If it is the last reference, disposes the value. */
dispose(): void {}
} |
hediet
approved these changes
Mar 7, 2024
alexr00
approved these changes
Mar 7, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CC: @hediet