Fix fullscreen container dimension detection when not directly on body#205884
Merged
bpasero merged 2 commits intomicrosoft:mainfrom Feb 23, 2024
Merged
Fix fullscreen container dimension detection when not directly on body#205884bpasero merged 2 commits intomicrosoft:mainfrom
bpasero merged 2 commits intomicrosoft:mainfrom
Conversation
Member
|
Is there an associated issue that this PR fixes? |
Contributor
Author
Not at all, it's more a code improvement than a bugfix since no issue can be reproduced in VSCode but it may impact forks and custom builds Should I still create an issue? |
Member
|
But how can we hard-code a reference to Note that your change impacts not only web but also VS Code for desktop. |
Contributor
Author
bpasero
requested changes
Feb 22, 2024
Member
bpasero
left a comment
There was a problem hiding this comment.
I see the issue now, I think having a comment to explain this would be good.
Co-authored-by: Benjamin Pasero <benjamin.pasero@gmail.com>
bpasero
approved these changes
Feb 22, 2024
Tyriar
approved these changes
Feb 22, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

If the workbench is rendered in another container than the body, everything works fine except the fullscreen mode.
This PR make the layout service not rely on the parent element size in fullscreen mode as it doesn't make sense and rely on the body size instead.
I don't think it can't break anything as in the browser, the parent element is currently already the main window body