Fix keyboard layout detection#205193
Merged
alexdima merged 2 commits intomicrosoft:mainfrom Mar 14, 2024
Merged
Conversation
alexdima
approved these changes
Mar 14, 2024
Member
|
Thank you! |
sandy081
approved these changes
Mar 14, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On google chrome inside a cross origin Iframe (or an iframe without the
keyboard-mappermission), it currently doesn't fallbacks on the keyboard event to detect the layout map.Also, the delay introduced by each failing call to
getLayoutMapwas making the fallback used too late and not working for the first time a key is used