fix: invalid endCharacter value in built in PHP validation provider #196166
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The build in PHP validation provider sets the Diagnostics Range endCharacter value to Number.MAX_VALUE. This ends up being translated to 1.7976931348623157e+308 in LSP communication with other LSs in the
textDocument/codeActionrequest.There was already a discussion and a fix for related issues: #80288 (comment)
Some parts of the codebase use Number.MAX_SAFE_INTEGER and one uses a hardcoded max 32 bit integer value:
vscode/src/vs/workbench/contrib/tasks/common/problemMatcher.ts
Line 450 in c05b497