add custom hover for quick open title bar buttons#191416
Merged
TylerLeonhardt merged 4 commits intomicrosoft:mainfrom Aug 30, 2023
Merged
add custom hover for quick open title bar buttons#191416TylerLeonhardt merged 4 commits intomicrosoft:mainfrom
TylerLeonhardt merged 4 commits intomicrosoft:mainfrom
Conversation
| })); | ||
|
|
||
| const delayer = new ThrottledDelayer(options.hoverDelegate.delay); | ||
| const delayer = new ThrottledDelayer(options.hoverDelegate ? options.hoverDelegate.delay : 200); |
Member
There was a problem hiding this comment.
All this stuff with the delayer and this.showHover is only going to happen if there is a hoverDelegate. Instead of doing the check for this.options.hoverDelegate in all these places, can you just not do any of this stuff if this.options.hoverDelegate isn't defined?
TylerLeonhardt
approved these changes
Aug 30, 2023
Member
|
Thanks for your patience! Great work :) |
roblourens
approved these changes
Aug 30, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
for: #186347