Increase shortcut consistency of web with electron.#191061
Merged
roblourens merged 2 commits intomicrosoft:mainfrom Aug 23, 2023
Merged
Increase shortcut consistency of web with electron.#191061roblourens merged 2 commits intomicrosoft:mainfrom
roblourens merged 2 commits intomicrosoft:mainfrom
Conversation
On electron, nothing changes. On web, * "Focus Application Menu" changes from F10 to Alt+F10 (this action only exists on web) * "Debugger: Step over" changes from Alt+F10 to F10 like on electron While microsoft#183510 already added the F10 binding for the debugger also on web, it did not actually have any effect, because of a conflict with F10 for "Focus Application Menu" on web. This change was agreed upon in microsoft#190180 due to the relatively low usage of "Open Application Menu" in the interest of more overall consistency. Fixes microsoft#190180.
TylerLeonhardt
approved these changes
Aug 23, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On electron, nothing changes.
On web,
While #183510 already added the F10 binding for the debugger also on web, it did not actually have any effect, because of a conflict with F10 for "Focus Application Menu" on web.
This change was agreed upon in #190180 due to the relatively low usage of "Open Application Menu" in the interest of more overall consistency.
Fixes #190180.