Rename TypeDefinitionProvider to TypeImplementationProvider#19101
Merged
mjbvz merged 2 commits intomicrosoft:masterfrom Jan 24, 2017
Merged
Rename TypeDefinitionProvider to TypeImplementationProvider#19101mjbvz merged 2 commits intomicrosoft:masterfrom
mjbvz merged 2 commits intomicrosoft:masterfrom
Conversation
**bug** In microsoft#18346, I originally called the new go to implementation provider api `ImplementationProvider` which we then decided to rename to `TypeDefinitionProvider`. At the time, I didn't realize that a type definition was actually its own, unrelated concept. **Fix** Rename `TypeDefinitionProvider` to `TypeImplementationProvider` to make it clear what the purpose and use of this api is.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #19099
bug
In #18346, I originally called the new
go to implementationprovider apiImplementationProviderwhich was a terrible name, so we then decided to rename the API toTypeDefinitionProvider. At the time, I didn't realize that atype definitionwas actually its own, unrelated concept.Fix
Rename
TypeDefinitionProvidertoTypeImplementationProviderto make it clear what the purpose and use of this API is.