Fix nested list style in Markdown preview#190936
Merged
mjbvz merged 1 commit intomicrosoft:mainfrom Aug 22, 2023
Merged
Conversation
mjbvz
approved these changes
Aug 22, 2023
rzhao271
approved these changes
Aug 22, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix #190860
There could be two cases for nested list:
renders into
renders into
PR #124445 fixed the first case, but did not take the second case into consideration. This PR carries the following modification:
ul ulwithmargin-bottom: 0, we set onlyul ul:first-child, which should match exactly the first case;margin-bottomof nested ul/ol, and further, we adjustli p'smargin-bottomto0.7em, which is the same as that of ul/ol and makes the style more consistent.