Ensure style element is added to shadowDOM components on colorizeElement#190505
Merged
hediet merged 3 commits intomicrosoft:mainfrom Aug 24, 2023
Merged
Ensure style element is added to shadowDOM components on colorizeElement#190505hediet merged 3 commits intomicrosoft:mainfrom
hediet merged 3 commits intomicrosoft:mainfrom
Conversation
hediet
approved these changes
Aug 24, 2023
Tyriar
approved these changes
Aug 24, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes microsoft/monaco-editor#4092
When
registerEditorContaineris called on shadow dom element, the<style>is attached to the element itself rather than todocument.body. Since colorize element replace the innerHTML with the new formatted code, it loses the<style>element that was just added.This PR moves the
registerEditorContainerto after the colorizeElement to ensure thestylewill be there.The changes was tested in this monaco playground following this guide