Add commands for collapsing/showing all unchanged regions#190451
Merged
hediet merged 3 commits intomicrosoft:mainfrom Aug 28, 2023
Merged
Add commands for collapsing/showing all unchanged regions#190451hediet merged 3 commits intomicrosoft:mainfrom
hediet merged 3 commits intomicrosoft:mainfrom
Conversation
2e8d260 to
85bdaa7
Compare
hediet
reviewed
Aug 15, 2023
| const unchangedRegions = this._diffModel.get()?.unchangedRegions.get(); | ||
| if (!unchangedRegions) { return; } | ||
| for (const region of unchangedRegions) { | ||
| region.collapseAll(undefined); |
Member
There was a problem hiding this comment.
They should run in a single transaction (transaction(tx => { /* use tx */ })), otherwise the editor will re-layout one time for every region.
hediet
reviewed
Aug 15, 2023
| const unchangedRegions = this._diffModel.get()?.unchangedRegions.get(); | ||
| if (!unchangedRegions) { return; } | ||
| for (const region of unchangedRegions) { | ||
| region.showAll(undefined); |
Contributor
Author
|
Wrapped the loop with one transaction. |
3605a15 to
121d7b1
Compare
DonJayamanne
approved these changes
Aug 28, 2023
DonJayamanne
approved these changes
Aug 28, 2023
hediet
approved these changes
Aug 28, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #188416