fix: devcontainer cache generation pipeline with Electron v25#189882
fix: devcontainer cache generation pipeline with Electron v25#189882deepak1556 wants to merge 1 commit intomainfrom
Conversation
|
Validation run https://github.com/microsoft/vscode/actions/runs/5791161324/job/15695513940 Need to update mcr.microsoft.com/vscode/devcontainers/repos/microsoft/vscode:dev to use Node.js v18, @chrmarti should I send a PR to bump the version in https://github.com/microsoft/vscode-dev-containers/blob/main/repository-containers/images/github.com/microsoft/vscode/.devcontainer/base.Dockerfile ? I see the repo is getting archived but I don't see a corresponding image in https://github.com/devcontainers/images/tree/main/src, so not sure where to direct the PR. |
|
@chrmarti is currently on vacation. @bamurtaugh can you clarify the above question, thanks! |
Yes, please go ahead and send a PR to vscode-dev-containers, thanks @deepak1556! cc @samruddhikhandale @alexdima I believe we still need to determine where to move the prebuilt VS Code image, but we should continue updating it in vscode-dev-containers at the moment. Please let me know if I'm forgetting anything. |
|
Thanks @bamurtaugh , PR at microsoft/vscode-dev-containers#1764 |
ea214ba to
261d8ba
Compare
261d8ba to
6278bd1
Compare
|
New run https://github.com/microsoft/vscode/actions/runs/5811776948/job/15766874284 confirmed that node-gyp missing error is addressed, but now there are errors in downloading playwright that is unrelated to the Electron update. @chrmarti passing this on to you since it requires changes in the container disk configuration. |
|
We removed the cache generation image. Closing. |
Addresses the failure seen in https://github.com/microsoft/vscode/actions/runs/5785283604/job/15678095549