Skip to content

testing: improve area below filter#189441

Merged
connor4312 merged 1 commit intomainfrom
connor4312/issue188841
Aug 2, 2023
Merged

testing: improve area below filter#189441
connor4312 merged 1 commit intomainfrom
connor4312/issue188841

Conversation

@connor4312
Copy link
Member

With results, the area is both more compact and useful. Passed/Total
tests are shown on the left, with an icon summarizing the view. On the
right, the wall-clock duration of the tests and a button to rerun tests.
The alt action on the button reruns the tests with the debugger.
Previously the rerun action was not very discoverable--had a few issues
about it over the course of time.

There's also no awkward gap when there's no test results:

Fixes #188841

cc @eleanorjboyd

With results, the area is both more compact and useful. Passed/Total
tests are shown on the left, with an icon summarizing the view. On the
right, the wall-clock duration of the tests and a button to rerun tests.
The alt action on the button reruns the tests with the debugger.
Previously the rerun action was not very discoverable--had a few issues
about it over the course of time.

![](https://memes.peet.io/img/23-08-8bb85d55-6304-4acb-bef3-9c1126da8c49.png)

There's also no awkward gap when there's no test results:

![](https://memes.peet.io/img/23-08-f5bcda56-60d7-4c8d-9822-e311b68079d7.png)

Fixes #188841

cc @eleanorjboyd
@connor4312 connor4312 enabled auto-merge (squash) August 2, 2023 01:16
@connor4312 connor4312 self-assigned this Aug 2, 2023
@vscodenpa vscodenpa added this to the August 2023 milestone Aug 2, 2023
@connor4312 connor4312 merged commit 360b462 into main Aug 2, 2023
@connor4312 connor4312 deleted the connor4312/issue188841 branch August 2, 2023 06:20
@github-actions github-actions bot locked and limited conversation to collaborators Sep 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Weird vertical gap between input and results in test view

3 participants