Merged
Conversation
Contributor
Author
|
@meganrogge @Tyriar Hi I just removed the judgment for the current screenReaderNotification, and after testing, if the variable has a value on each click, the close operation is called first, so it is fine for the logic. The reason for the change is that the notification center cannot determine whether the notification that the current pop-up wants to pop up already exists, so I used this solution, and I also referred to some other similar behavior features, e.g., the copilot extension, his behavior is also to pop up a notification every time you click, and It seems that their behavior is consistent for now |
meganrogge
reviewed
Jul 31, 2023
meganrogge
approved these changes
Jul 31, 2023
Collaborator
|
thanks @weartist! |
andreamah
approved these changes
Jul 31, 2023
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix: #188760