Skip to content

Fix: #188760#189259

Merged
meganrogge merged 1 commit intomicrosoft:mainfrom
Kalmaegi:fix_reader_optimized_notification
Jul 31, 2023
Merged

Fix: #188760#189259
meganrogge merged 1 commit intomicrosoft:mainfrom
Kalmaegi:fix_reader_optimized_notification

Conversation

@Kalmaegi
Copy link
Contributor

Fix: #188760

@Kalmaegi
Copy link
Contributor Author

Kalmaegi commented Jul 30, 2023

@meganrogge @Tyriar Hi I just removed the judgment for the current screenReaderNotification, and after testing, if the variable has a value on each click, the close operation is called first, so it is fine for the logic.

The reason for the change is that the notification center cannot determine whether the notification that the current pop-up wants to pop up already exists, so I used this solution, and I also referred to some other similar behavior features, e.g., the copilot extension, his behavior is also to pop up a notification every time you click, and It seems that their behavior is consistent for now

@meganrogge
Copy link
Collaborator

thanks @weartist!

@meganrogge meganrogge enabled auto-merge July 31, 2023 15:06
@meganrogge meganrogge merged commit 13cfee1 into microsoft:main Jul 31, 2023
@beto811 beto811 mentioned this pull request Jul 31, 2023
@andreamah andreamah added this to the August 2023 milestone Jul 31, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Sep 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Clicking screen reader optimized button should re-show notification

3 participants