Fixes extension activation fail after upgrade with Error: Cannot find module 'vscode'#187090
Merged
Conversation
Contributor
Author
|
ping @alexdima |
Member
|
Appologies I only saw this now, I'll try to get it with the next recovery. |
alexdima
approved these changes
Jul 18, 2023
alexdima
left a comment
Member
There was a problem hiding this comment.
The fix is spot on! Thank you!
ulugbekna
approved these changes
Jul 18, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #185733
cc @alexdima
Can this be scheduled for next release 1.80 or recovery release 🙏? it's affecting my extension as it will fail to activate using
onUrievent