Skip to content

Markdown fixes#18704

Merged
mjbvz merged 4 commits intomicrosoft:masterfrom
morags:morags/markdown_fixes
Jan 20, 2017
Merged

Markdown fixes#18704
mjbvz merged 4 commits intomicrosoft:masterfrom
morags:morags/markdown_fixes

Conversation

@morags
Copy link
Copy Markdown
Contributor

@morags morags commented Jan 18, 2017

Added several languages and fixed a typo in markdown.tmLanguage.

@msftclas
Copy link
Copy Markdown

msftclas commented Jan 18, 2017

Hi @morags, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!

In order for us to evaluate and accept your PR, we ask that you sign a contribution license agreement. It's all electronic and will take just minutes. I promise there's no faxing. https://cla.microsoft.com.

TTYL, MSBOT;

@msftgits
Copy link
Copy Markdown

msftgits commented Jan 18, 2017

Hi, I am closing and re-opening this PR to bump the CLA bot. Sorry for the inconvenience!

@msftgits msftgits closed this Jan 18, 2017
@msftgits msftgits reopened this Jan 18, 2017
@msftclas
Copy link
Copy Markdown

msftclas commented Jan 18, 2017

Hi @morags, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!
You've already signed the contribution license agreement. Thanks!
We will now validate the agreement and then real humans will evaluate your PR.

TTYL, MSBOT;

@mjbvz mjbvz self-assigned this Jan 19, 2017
mjbvz
mjbvz reviewed Jan 19, 2017
View reviewed changes
extensions/markdown/syntaxes/markdown.tmLanguage
</dict>
</array>
</dict>
<key>fenced_code_block_rust</key>
Copy link
Copy Markdown
Collaborator

@mjbvz mjbvz Jan 19, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update these to use the fenced code block logic that the other languages now use. It's rather horrific but it fixes a few important edge cases

@mjbvz mjbvz added this to the January 2017 milestone Jan 20, 2017
@mjbvz mjbvz merged commit 22cc4a1 into microsoft:master Jan 20, 2017
@mjbvz
Copy link
Copy Markdown
Collaborator

mjbvz commented Jan 20, 2017

Thank you for these improvements. They should be in the next insiders build

@morags
Copy link
Copy Markdown
Contributor Author

morags commented Jan 20, 2017

Thank you.

@github-actions github-actions bot locked and limited conversation to collaborators Mar 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@mjbvz mjbvz mjbvz left review comments

Assignees

@kieferrm kieferrm

@mjbvz mjbvz

Labels

None yet

Projects

None yet

Milestone

January 2017

Development

Successfully merging this pull request may close these issues.

5 participants

@morags @msftclas @msftgits @mjbvz @kieferrm