fix: color hints may display twice(#175476)#186926
Conversation
There was a problem hiding this comment.
Hi thanks for the work, after a second look I notice that the unit tests are failing. The end offset is not calculated correctly according to these tests. Some more work will need to be done to find a fix. Unfortunately we can not merge it with the unit tests failing.
Hi Aiday, I checked the failing test case, found the token endIndex is 30, it's also the last column of a line. I think inline decoration's endOffset shouldn't be greater than line's last column, should we update the failing test case? Please check. |
|
@yshaojun thanks for fixing this! |

fix #175476