Skip to content

Add proposed api to support auto closing pairs on langauge configuration#186567

Merged
alexdima merged 8 commits into
microsoft:mainfrom
colombod:auto_close_quote
Jul 14, 2023
Merged

Add proposed api to support auto closing pairs on langauge configuration#186567
alexdima merged 8 commits into
microsoft:mainfrom
colombod:auto_close_quote

Conversation

@colombod

@colombod colombod commented Jun 28, 2023

Copy link
Copy Markdown
Contributor

This pr provides support for auto closing pairs on language configuration

@colombod

Copy link
Copy Markdown
Contributor Author

@jrieken, @alexdima this is the pr to address #173738

@rebornix rebornix requested a review from alexdima June 28, 2023 21:19
alexdima
alexdima previously approved these changes Jul 14, 2023

@alexdima alexdima left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great! Thank you!

@alexdima alexdima added this to the July 2023 milestone Jul 14, 2023
@alexdima alexdima enabled auto-merge July 14, 2023 12:15
@alexdima alexdima disabled auto-merge July 14, 2023 12:15
@alexdima alexdima enabled auto-merge (squash) July 14, 2023 12:15
Comment thread src/vs/workbench/api/common/extHostLanguageFeatures.ts
@alexdima alexdima merged commit 8e1ae0d into microsoft:main Jul 14, 2023
@colombod colombod deleted the auto_close_quote branch July 26, 2023 11:26
@github-actions github-actions Bot locked and limited conversation to collaborators Aug 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants