Fix bug in decorationRenderHelper#18361
Merged
aeschli merged 1 commit intomicrosoft:masterfrom Jan 19, 2017
nojvek:decorationHelperBugFix
Merged
Fix bug in decorationRenderHelper#18361aeschli merged 1 commit intomicrosoft:masterfrom nojvek:decorationHelperBugFix
aeschli merged 1 commit intomicrosoft:masterfrom
nojvek:decorationHelperBugFix
Conversation
getCSSTextForModelDecorationContentClassName will not escape ' in contentText since its escaping " rather than '
_CSS_MAPcontentText: 'content:\'{0}\';' uses single apostrophe so we need to escape ' rather than "
This is a bug that was always present and breaks inlineValueDebugging feature I am working on #16129
Contributor
Author
|
@isidorn any chance you could take a quick look at this. This is ported from the other PR as you had requested. |
Contributor
Author
|
Notes from other PR: Without this fix, python string values won't show up. Since python strings show up as |
Collaborator
|
@alexandrudima as @nojvek explains the other PR #16129 depends on this as this seems to be the issue with handling of python words. |
Contributor
|
Thanks @nojvek ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
getCSSTextForModelDecorationContentClassName will not escape ' in contentText since its escaping " rather than '
_CSS_MAPcontentText: 'content:'{0}';' uses single apostrophe so we need to escape ' rather than "
This is a bug that was always present and breaks inlineValueDebugging feature I am working on #16129