Respect gitignore file even when not in a git repository#183368
Merged
Conversation
Contributor
Author
|
@microsoft-github-policy-service agree |
Contributor
|
Looks good! Haven't tested it quite yet, but could you fix the failing test here? Seems that it's not passing CI. |
bab5d79 to
d4c4377
Compare
If a .gitignore file exists in a workspace, we currently only respect it if we're also in a git repository. This is because of ripgrep's default behavior. Pass an extra flag to ripgrep so that it always respects the .gitignore file if it exists.
d4c4377 to
0b9e3ed
Compare
Contributor
Author
|
@andreamah , the test should now be passing. Anything else needed to get this in? |
amunger
approved these changes
Jun 5, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If a .gitignore file exists in a workspace, we currently only respect it
if we're also in a git repository. This is because of ripgrep's default
behavior. Pass an extra flag to ripgrep so that it always respects the
.gitignore file if it exists.
Fixes #182958