wrap handler for resize observer in requestAnimationFrame()#183325
Merged
alexdima merged 6 commits intomicrosoft:mainfrom Aug 31, 2023
Merged
wrap handler for resize observer in requestAnimationFrame()#183325alexdima merged 6 commits intomicrosoft:mainfrom
alexdima merged 6 commits intomicrosoft:mainfrom
Conversation
thari
approved these changes
Jun 8, 2023
Hypenate
approved these changes
Jun 13, 2023
… only delay the second notification during the same animation frame
alexdima
approved these changes
Jul 27, 2023
Contributor
Author
|
@microsoft-github-policy-service agree |
Contributor
Author
|
@alexdima thank you for taking care of this!! 🙏 |
simonh1000
approved these changes
Aug 18, 2023
DonJayamanne
approved these changes
Aug 18, 2023
Contributor
Author
|
@alexdima I see that we have enough approvals. Is it ok to close this PR? |
|
Is this fix being added to Monaco - that's where I need it and 0.43 continues to exhibit this bug |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Wrapping the
ResizeObservercallback inrequestAnimationFrame()should avoid the "loop limit exceeded" error which pops up under certain circumstances.(fixes #183324)