only reconnect to isBackground task terminals#181430
Merged
Merged
Conversation
Tyriar
approved these changes
May 3, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To test:
Using
xterm.js, modify theStart demotask so none of its dependencies haveisBackground:true. Start that task and reload the window. 🐛 , without these changes, the tasks are still running but the task system doesn't know that. With these changes, the task terminals should no longer be there.Context:
We wanted to keep terminals around that had tasks run in them regardless of whether or not those tasks persisted. In doing that, the tasks were never terminated. We could keep the terminals around after reload, but I think that's confusing and we should just kill them.
Also see #180374 (comment)
An exploration into a different approach - where we would reconnect to non background tasks as well:
#180243 (comment)
fixes #180243