Skip to content

Added use snippet body as a description when none is provided #181115#181381

Merged
jrieken merged 6 commits into
microsoft:mainfrom
TheSylvester:feature-181115-snippets-fill-empty-description
May 10, 2023
Merged

Added use snippet body as a description when none is provided #181115#181381
jrieken merged 6 commits into
microsoft:mainfrom
TheSylvester:feature-181115-snippets-fill-empty-description

Conversation

@TheSylvester

@TheSylvester TheSylvester commented May 3, 2023

Copy link
Copy Markdown
Contributor

edit: added word "implemented"

TheSylvester and others added 2 commits May 3, 2023 01:41
- use snippet body as a description when none is provided #181115
- editor.snippets.fillDescriptions.enabled toggle in settings
@TheSylvester

Copy link
Copy Markdown
Contributor Author

@microsoft-github-policy-service agree

@jrieken jrieken added this to the May 2023 milestone May 3, 2023
@jrieken

jrieken commented May 3, 2023

Copy link
Copy Markdown
Contributor

@TheSylvester Thanks. This is already looking pretty good.

editor.snippets.fillDescriptions.enabled toggle in settings

I would like to disagree with that and implement this w/o setting.

@TheSylvester

Copy link
Copy Markdown
Contributor Author

editor.snippets.fillDescriptions.enabled toggle in settings

I would like to disagree with that and implement this w/o setting.

I should clarify that I implemented a setting to toggle this to be enabled. By default I've set this to be false to be optionally enabled, unless you see something different?

@jrieken

jrieken commented May 3, 2023

Copy link
Copy Markdown
Contributor

I should clarify that I implemented a setting to toggle this to be enabled. By default I've set this to be false to be optionally enabled, unless you see something different?

That's what I see but I am saying that a setting isn't needed. This is an improvement and shouldn't be behind a setting but just happen

@TheSylvester

Copy link
Copy Markdown
Contributor Author

I see! I was just following the ethos of making as few changes as possible, especially to default behaviour. Just accounting for folks who would appreciate being able to see their snippet without the description (maybe that's why they didn't put one in).

There's definitely a case for making this default true but I leave that up to the maintainers.

@jrieken

jrieken commented May 9, 2023

Copy link
Copy Markdown
Contributor

I was just following the ethos of making as few changes as possible, especially to default behaviour

We take improvement without setting, so please remove that part in the PR

@TheSylvester

Copy link
Copy Markdown
Contributor Author

Thank you for confirming. I've made the required changes. Kindly let me know if there's anything else required.

@jrieken jrieken left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@jrieken jrieken merged commit 3242ce2 into microsoft:main May 10, 2023
@github-actions github-actions Bot locked and limited conversation to collaborators Jun 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants