#14464 Preserve editor size when switching layout#17760
#14464 Preserve editor size when switching layout#17760bpasero merged 2 commits intomicrosoft:masterfrom
Conversation
|
Hi @charlespierce, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution! TTYL, MSBOT; |
|
Hi @charlespierce, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution! TTYL, MSBOT; |
bpasero
left a comment
There was a problem hiding this comment.
@charlespierce very nice. only comment I have is to not expose the "keep ratio" thing to the API because it seems noone outside the editor groups control would ever use it.
There was a problem hiding this comment.
Suggest to not introduce a GroupArrangement.KEEP_RATIO but rather allow to call arrangeGroups without any parameter and then use that as an indication to "keep the ratio". I would not expose this as API but just set the arrangement optional here in this file.
7790ab5 to
38038ba
Compare
|
@bpasero Removed |
|
@charlespierce thanks 👍 |
Implementation of #14464
Currently when switching from horizontal to vertical editor layout (or vice-versa), the layout is reset to all editors being evenly sized. We would like it if the editors maintained their relative size when switching layouts.
Additionally, the minimized state of any editors should be preserved so that editors that were minimized in one layout are still minimized after switching.