Fixes configured default shell not used when connecting to remote#175844
Merged
Tyriar merged 6 commits intomicrosoft:mainfrom Mar 29, 2023
Merged
Fixes configured default shell not used when connecting to remote#175844Tyriar merged 6 commits intomicrosoft:mainfrom
Tyriar merged 6 commits intomicrosoft:mainfrom
Conversation
jeanp413
commented
Mar 2, 2023
Comment on lines
+44
to
+48
| for (const remoteAuthority of [undefined, _environmentService.remoteAuthority]) { | ||
| let resolve: () => void; | ||
| const p = new Promise<void>(r => resolve = r); | ||
| this._backendRegistration.set(remoteAuthority, { promise: p, resolve: resolve! }); | ||
| } |
Contributor
Author
There was a problem hiding this comment.
RemoteTerminalBackendContribution is registered to be created on restored phase but instantiation only occurs when idle.
Contributor
Author
|
ping @Tyriar |
Tyriar
approved these changes
Mar 29, 2023
Member
Tyriar
left a comment
There was a problem hiding this comment.
LGTM! Thanks for looking into this, very long standing and annoying issue ❤️
Member
|
FYI @jkeech, this was a elusive Codespaces bug that had some partial fixes previously. |
bpasero
approved these changes
Mar 29, 2023
alexr00
approved these changes
Mar 29, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #175107