Fix 'Window' key is treated as 'unknown' in Firefox (#175739)#175740
Merged
ulugbekna merged 2 commits intoMar 28, 2023
Conversation
Author
|
@microsoft-github-policy-service agree |
ulugbekna
approved these changes
Mar 17, 2023
ulugbekna
left a comment
Contributor
There was a problem hiding this comment.
Changes look correct to me.
Member
|
I did a quick pass over various combinations we support, here's what I noticed using a w3c test page:
@ulugbekna Does this match what you tested as well? |
Contributor
|
Yes, but I used vscode and vscode.dev "kb troubleshooting"; didn't know about this website :D
|
alexdima
approved these changes
Mar 27, 2023
ulugbekna
approved these changes
Mar 28, 2023
Contributor
|
Thanks @YinDongFang :-) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix #175739
eventKeyCodeto91forKeyCode.MetakeyCode === 91forisWebKit