fix: fallback to editor hover if can't evaluate debug expression - (#169151)#173482
Merged
roblourens merged 8 commits intoApr 5, 2023
Merged
Conversation
f62e054 to
9be87c8
Compare
roblourens
reviewed
Mar 24, 2023
7e91ec9 to
8a976d6
Compare
roblourens
previously approved these changes
Mar 28, 2023
roblourens
reviewed
Mar 28, 2023
97d0f42 to
970a610
Compare
roblourens
reviewed
Mar 31, 2023
roblourens
approved these changes
Apr 5, 2023
roblourens
left a comment
Member
There was a problem hiding this comment.
Just pushed a commit to restore some deleted newlines, and overall it looks great, thanks for the contribution!
joyceerhl
approved these changes
Apr 5, 2023
Contributor
Author
Thanks for the great review |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #169151
As proposed in this comment #169151 (comment), If a expression cannot be evaluated within the active debug context , the normal editor hover is shown.
The above action applies to both keyboard and muse initiated hover action.