Layout when switching from welcome to terminal.#173368
Merged
Tyriar merged 9 commits intomicrosoft:mainfrom Oct 31, 2023
Merged
Layout when switching from welcome to terminal.#173368Tyriar merged 9 commits intomicrosoft:mainfrom
Tyriar merged 9 commits intomicrosoft:mainfrom
Conversation
Before this change, VSCode assumed in multiple places that we only ever either have terminals open (on desktop) or a "welcome" screen (on web, explaining that terminals are not supported). Switching between the two causes a broken layout. This is currently not visible in VSCode because VSCode opens a new terminal as soon as the terminal panel is opened, and closes the terminal panel when the last terminal is closed. With this change, that assumption is removed and the question whether a welcome screen is available is centralized in one place. This makes it easier for downstream forks to have a welcome screen when first opening the panel, and when the last terminal is closed. In VSCode itself, this still works as before. This change also removes relying on the side-effect of the `shouldShowWelcome` getter to write a member variable, and removes superfluously setting that member variable when is it already set.
Contributor
Author
|
Any update here? Do you need anything from me? |
Contributor
Author
|
Hi @sbatten, is there any chance this will be reviewed? Should I update the PR one more time? Or do you have a general concern with this change and the PR should be declined? |
Member
Tyriar
previously approved these changes
Oct 31, 2023
Contributor
Tyriar
left a comment
There was a problem hiding this comment.
Thanks and sorry about the delay 😅
Not sure how to test welcome screens but we'll make sure it gets verified in vscode.dev
lramos15
approved these changes
Oct 31, 2023
Tyriar
approved these changes
Oct 31, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before this change, VSCode assumed in multiple places that we only ever either have terminals open (on desktop) or a "welcome" screen (on web, explaining that terminals are not supported). Switching between the two causes a broken layout. This is currently not visible in VSCode because VSCode opens a new terminal as soon as the terminal panel is opened, and closes the terminal panel when the last terminal is closed.
With this change, that assumption is removed and the question whether a welcome screen is available is centralized in one place. This makes it easier for downstream forks to have a welcome screen when first opening the panel, and when the last terminal is closed. In VSCode itself, this still works as before.
This change also removes relying on the side-effect of the
shouldShowWelcomegetter to write a member variable, and removes superfluously setting that member variable when is it already set.