Skip to content

Issue 151220/add current timezone offset variable#170518

Merged
jrieken merged 4 commits into
microsoft:mainfrom
MonadChains:issue-151220/add-CURRENT-TIMEZONE-OFFSET-VARIABLE
Apr 24, 2023
Merged

Issue 151220/add current timezone offset variable#170518
jrieken merged 4 commits into
microsoft:mainfrom
MonadChains:issue-151220/add-CURRENT-TIMEZONE-OFFSET-VARIABLE

Conversation

@MonadChains

@MonadChains MonadChains commented Jan 3, 2023

Copy link
Copy Markdown
Contributor

Solves #151220

mattjohnsonpint
mattjohnsonpint reviewed Jan 3, 2023
View reviewed changes
Comment thread src/vs/editor/contrib/snippet/browser/snippetVariables.ts Outdated
@mattjohnsonpint

mattjohnsonpint commented Jan 3, 2023

Copy link
Copy Markdown

Please also add tests, or update these ones. Thanks.

vscode/src/vs/editor/contrib/snippet/test/browser/snippetVariables.test.ts

Lines 293 to 339 in 4acf2d9

test('Add time variables for snippets #41631, #43140', function () {
const resolver = new TimeBasedVariableResolver;
assertVariableResolve3(resolver, 'CURRENT_YEAR');
assertVariableResolve3(resolver, 'CURRENT_YEAR_SHORT');
assertVariableResolve3(resolver, 'CURRENT_MONTH');
assertVariableResolve3(resolver, 'CURRENT_DATE');
assertVariableResolve3(resolver, 'CURRENT_HOUR');
assertVariableResolve3(resolver, 'CURRENT_MINUTE');
assertVariableResolve3(resolver, 'CURRENT_SECOND');
assertVariableResolve3(resolver, 'CURRENT_DAY_NAME');
assertVariableResolve3(resolver, 'CURRENT_DAY_NAME_SHORT');
assertVariableResolve3(resolver, 'CURRENT_MONTH_NAME');
assertVariableResolve3(resolver, 'CURRENT_MONTH_NAME_SHORT');
assertVariableResolve3(resolver, 'CURRENT_SECONDS_UNIX');
});
test('Time-based snippet variables resolve to the same values even as time progresses', async function () {
const snippetText = `
$CURRENT_YEAR
$CURRENT_YEAR_SHORT
$CURRENT_MONTH
$CURRENT_DATE
$CURRENT_HOUR
$CURRENT_MINUTE
$CURRENT_SECOND
$CURRENT_DAY_NAME
$CURRENT_DAY_NAME_SHORT
$CURRENT_MONTH_NAME
$CURRENT_MONTH_NAME_SHORT
$CURRENT_SECONDS_UNIX
`;
const clock = sinon.useFakeTimers();
try {
const resolver = new TimeBasedVariableResolver;
const firstResolve = new SnippetParser().parse(snippetText).resolveVariables(resolver);
clock.tick((365 * 24 * 3600 * 1000) + (24 * 3600 * 1000) + (3661 * 1000)); // 1 year + 1 day + 1 hour + 1 minute + 1 second
const secondResolve = new SnippetParser().parse(snippetText).resolveVariables(resolver);
assert.strictEqual(firstResolve.toString(), secondResolve.toString(), `Time-based snippet variables resolved differently`);
} finally {
clock.restore();
}
});

@MonadChains MonadChains dismissed a stale review via 80ac0f3 January 3, 2023 23:15
@MonadChains

MonadChains commented Jan 4, 2023

Copy link
Copy Markdown
Contributor Author

@mattjohnsonpint I've add the new variable to the tests

@mattjohnsonpint

mattjohnsonpint commented Jan 6, 2023

Copy link
Copy Markdown

LGTM, but I'm not a maintainer of this repo.

@mitechzone mitechzone mentioned this pull request Feb 24, 2023
Closed
@ericthomas1 ericthomas1 mentioned this pull request Mar 7, 2023
Closed
@redactedscribe

redactedscribe commented Apr 23, 2023

Copy link
Copy Markdown

@jrieken Any chance we could get this PR approved? Would love to see this in VS Code.

@jrieken

jrieken commented Apr 24, 2023

Copy link
Copy Markdown
Contributor

Yeah, this slipped my inbox.

@jrieken jrieken added this to the April 2023 milestone Apr 24, 2023
@jrieken jrieken merged commit 0a6b7a3 into microsoft:main Apr 24, 2023
@redactedscribe redactedscribe mentioned this pull request Apr 25, 2023
Closed
@redactedscribe

redactedscribe commented May 22, 2023

Copy link
Copy Markdown

Just FYI, this new variable isn't documented on https://code.visualstudio.com/docs/editor/userdefinedsnippets

@github-actions github-actions Bot locked and limited conversation to collaborators Jun 8, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@ulugbekna ulugbekna ulugbekna approved these changes

+2 more reviewers

@mattjohnsonpint mattjohnsonpint mattjohnsonpint approved these changes

@jrieken jrieken jrieken approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@jrieken jrieken

Labels

snippets

Projects

None yet

Milestone

April 2023

Development

Successfully merging this pull request may close these issues.

5 participants

@MonadChains @mattjohnsonpint @redactedscribe @jrieken @ulugbekna